fix(settings): correctly detect Chrome on Android in devices & sessions by chandrika1993 · Pull Request #58739 · nextcloud/server

chandrika1993 · 2026-03-05T16:11:32Z

Resolves: [Bug]: In /settings/user/security Chrome on Android is detected as Chrome on Linux #50502

Summary

Chrome on Android was incorrectly displayed as Google Chrome (Linux) in the
Devices & Sessions list at /settings/user/security.

Two compounding issues caused this:

Android Chrome UA strings contain Linux (Android is Linux-based), so the
generic chrome regex matched before androidChrome was ever reached.
Since 2021, Google reduced Android Chrome's UA — the Build/ token is no
longer included, so the old androidChrome regex failed to match modern
Android Chrome entirely.

Fix:

Updated androidChrome regex to match both modern (no Build/) and legacy
(with Build/) Android Chrome UA formats
Added negative lookahead (?![^)]*Android) to chrome and firefox regexes
Moved androidChrome before chrome in userAgentMap as defense in depth

Before / After:

	Before	After
Label	`Google Chrome - 132 (Linux)` ❌	`Google Chrome for Android - 132` ✅
Icon	🌐 Chrome	🤖 Android

❌ Before (Bug)

✅ After (Fixed)

Note: This PR supersedes #56450 which addresses the modern UA format
but does not fix the underlying map ordering issue that would still
allow the chrome regex to match Android UAs first. This PR combines
both fixes for a complete solution.

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit) are included — 13 tests added and passing
Screenshots before/after included above
Documentation not required
Backports requested where applicable
Labels added — bug, feature: settings, 3. to review
Milestone added

AI (if applicable)

The content of this PR was partly or fully generated using AI

cc @skjnldsv @provokateurin @sorbaugh @nfebe

artonge

Hey, thanks for the PR.

Can you manually review your tests cases to ensure that they only test the result of the detect function and not its implementation. And also ensure that each test case actually make sense?

Please also address the other comments.

apps/settings/src/components/AuthToken.spec.ts

chandrika1993 · 2026-03-10T20:11:27Z

Hi @artonge,

Thanks for the review. I have addressed all the suggested changes. Let me know if anything else is needed.

Also, apologies for the noise, I accidentally rebased my branch with master, which triggered auto-assignment of several reviewers. I've since reverted to the original state. Could you help remove the extra reviewers?

Best,
Chandrika

chandrika1993 · 2026-03-16T16:46:57Z

npm is still not right, please run the commands from above, commit all the resulting changes and amend your last commit before you force push

Please check I did the requested

you need to commit the files in the /js/ folder - js.min and js.min.map files

Hi, I ran npm ci && npm run build but the build is not generating any .min.js files. The build output goes to the dist/ folder as .js files (e.g. dist/settings-vue-settings-personal-security.js) which are already minified and committed. Could you point me to the exact build command that generates .min.js files, or confirm if the dist/ files I've already committed are sufficient?

apps/settings/src/components/AuthToken.spec.ts

miaulalala · 2026-03-18T11:09:18Z

npm is still not right, please run the commands from above, commit all the resulting changes and amend your last commit before you force push

Please check I did the requested

you need to commit the files in the /js/ folder - js.min and js.min.map files

Hi, I ran npm ci && npm run build but the build is not generating any .min.js files. The build output goes to the dist/ folder as .js files (e.g. dist/settings-vue-settings-personal-security.js) which are already minified and committed. Could you point me to the exact build command that generates .min.js files, or confirm if the dist/ files I've already committed are sufficient?

ah, sorry, run the commands within the apps/settings folder then you should see the JS changes.

miaulalala

LGTM!

artonge · 2026-03-19T10:23:20Z

/compile rebase /

miaulalala · 2026-03-19T14:00:20Z

@chandrika1993 can you allow maintainer changes? Then we can run the nextcloud bot that will compile the JS again.

artonge · 2026-03-19T15:38:26Z

/compile rebase /

miaulalala · 2026-03-19T16:23:20Z

/compile amend

miaulalala · 2026-03-19T16:35:05Z

@chandrika1993 you need to solve the conflicts before we can merge

Please run a rebase. The conflict on the dist folder you can resolve in any way you like as they'll be regenerated anyway.

After you've run the rebase and resolved the conflicts, rerun npm ci && npm run build in the settings app, add the new generated files in the /dist/ folder and amend you last commit.

chandrika1993 · 2026-03-19T18:12:07Z

@chandrika1993 you need to solve the conflicts before we can merge

Please run a rebase. The conflict on the dist folder you can resolve in any way you like as they'll be regenerated anyway.

After you've run the rebase and resolved the conflicts, rerun npm ci && npm run build in the settings app, add the new generated files in the /dist/ folder and amend you last commit.

The branch is updated now

miaulalala · 2026-03-19T20:58:21Z

you need to compile the js code again

github-actions · 2026-03-20T02:13:36Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Signed-off-by: Chandrika Mohan <chandrikalov@gmail.com> common logic to detect ua Signed-off-by: Chandrika Mohan <chandrikalov@gmail.com>

chandrika1993 · 2026-03-20T13:14:25Z

you need to compile the js code again

Hi @miaulalala , I've completed the rebase, resolved the dist conflicts, reran npm ci && npm run build in the settings app, and amended the commit with the freshly generated dist files.

If the compiled output still doesn't look right on your end, it would be really helpful if you could run the build locally and verify, I want to make sure everything is correct before this gets merged.

Thanks for your patience and support! 🙏

miaulalala · 2026-03-22T08:07:54Z

@AndyScherzinger or @artonge can you force merge?

welcome · 2026-03-22T09:24:13Z

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

chandrika1993 requested a review from a team as a code owner March 5, 2026 16:11

chandrika1993 requested review from artonge, skjnldsv and szaimen and removed request for a team March 5, 2026 16:11

chandrika1993 mentioned this pull request Mar 5, 2026

[Bug]: In /settings/user/security Chrome on Android is detected as Chrome on Linux #50502

Closed

8 tasks

artonge added 3. to review Waiting for reviews feature: settings javascript AI assisted labels Mar 10, 2026

artonge added this to the Nextcloud 34 milestone Mar 10, 2026

artonge reviewed Mar 10, 2026

View reviewed changes

chandrika1993 force-pushed the fix/issue-50502 branch from e5490b6 to b484cde Compare March 10, 2026 19:45

chandrika1993 requested review from a team, ChristophWurst, SebastianKrupinski, blizzz, hamza221, miaulalala, nickvergessen, provokateurin and tcitworld as code owners March 10, 2026 19:45

chandrika1993 requested review from ArtificialOwl, artonge and leftybournes and removed request for a team March 10, 2026 19:45

chandrika1993 force-pushed the fix/issue-50502 branch 2 times, most recently from 0f234dc to a17dd64 Compare March 10, 2026 20:02

artonge reviewed Mar 18, 2026

View reviewed changes

apps/settings/src/components/AuthToken.spec.ts Outdated Show resolved Hide resolved

chandrika1993 force-pushed the fix/issue-50502 branch 3 times, most recently from e81d75f to 65316c3 Compare March 18, 2026 15:08

miaulalala approved these changes Mar 18, 2026

View reviewed changes

artonge approved these changes Mar 18, 2026

View reviewed changes

artonge mentioned this pull request Mar 18, 2026

[local] fix(settings): correctly detect Chrome on Android in devices & sessions #59045

Draft

artonge enabled auto-merge March 18, 2026 16:58

auto-merge was automatically disabled March 19, 2026 16:37
Head branch was pushed to by a user without write access

chandrika1993 force-pushed the fix/issue-50502 branch 2 times, most recently from c279871 to c3864a5 Compare March 19, 2026 18:07

chandrika1993 force-pushed the fix/issue-50502 branch from c3864a5 to 3ec0b55 Compare March 19, 2026 20:08

github-actions bot added the feedback-requested label Mar 20, 2026

chandrika1993 force-pushed the fix/issue-50502 branch from 3ec0b55 to 4247c60 Compare March 20, 2026 12:20

fix(settings): correctly detect Chrome on Android in devices & sessions

38278d1

Signed-off-by: Chandrika Mohan <chandrikalov@gmail.com> common logic to detect ua Signed-off-by: Chandrika Mohan <chandrikalov@gmail.com>

chandrika1993 force-pushed the fix/issue-50502 branch from 4247c60 to 38278d1 Compare March 20, 2026 13:10

AndyScherzinger merged commit 4a88f93 into nextcloud:master Mar 22, 2026
114 of 120 checks passed

Uh oh!

Conversation

chandrika1993 commented Mar 5, 2026 • edited by AndyScherzinger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

❌ Before (Bug)

✅ After (Fixed)

Checklist

AI (if applicable)

Uh oh!

artonge left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chandrika1993 commented Mar 10, 2026

Uh oh!

chandrika1993 commented Mar 16, 2026

Uh oh!

Uh oh!

miaulalala commented Mar 18, 2026

Uh oh!

miaulalala left a comment

Choose a reason for hiding this comment

Uh oh!

artonge commented Mar 19, 2026

Uh oh!

miaulalala commented Mar 19, 2026

Uh oh!

artonge commented Mar 19, 2026

Uh oh!

miaulalala commented Mar 19, 2026

Uh oh!

miaulalala commented Mar 19, 2026

Uh oh!

chandrika1993 commented Mar 19, 2026

Uh oh!

miaulalala commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

chandrika1993 commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miaulalala commented Mar 22, 2026

Uh oh!

Uh oh!

welcome bot commented Mar 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chandrika1993 commented Mar 5, 2026 •

edited by AndyScherzinger

Loading

chandrika1993 commented Mar 20, 2026 •

edited

Loading